Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable release justification #86757

Conversation

kpatron-cockroachlabs
Copy link
Contributor

Once the release-22.2 branch is cut we can disable release justification
githook check and let blathers justification check take over.

Notes:

  • to be merged after the release 22.2 branch cut
  • blathers/release-justification-check will pass after STABILITY_PERIOD
    is turned off [as part of the branch cut playbook]

Release note: None
Release justification: internal-only / non-production
/ release-process code change

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kpatron-cockroachlabs kpatron-cockroachlabs changed the title build disable release justification build: disable release justification Aug 24, 2022
Once the release-22.2 branch is cut we can disable release justification
githook check and let blathers justification check take over.

Notes:
* to be merged after the release 22.2 branch cut
* `blathers/release-justification-check` will pass after `STABILITY_PERIOD`
is turned off [as part of the branch cut playbook]

Release note: None
Release justification: internal-only / non-production
/ release-process code change
@kpatron-cockroachlabs kpatron-cockroachlabs force-pushed the kpatron/disable-justification-22.2 branch from 5ad39f1 to daf9a9d Compare August 24, 2022 14:10
Copy link
Collaborator

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - LGTM!

@kpatron-cockroachlabs
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 7, 2022

Build succeeded:

@craig craig bot merged commit 99a9587 into cockroachdb:master Sep 7, 2022
@kpatron-cockroachlabs kpatron-cockroachlabs deleted the kpatron/disable-justification-22.2 branch September 7, 2022 22:44
craig bot pushed a commit that referenced this pull request Sep 8, 2022
87537: release-22.2: build: disable release justification r=kpatron-cockroachlabs a=blathers-crl[bot]

Backport 1/1 commits from #86757 on behalf of `@kpatron-cockroachlabs.`

/cc `@cockroachdb/release`

----

Once the release-22.2 branch is cut we can disable release justification
githook check and let blathers justification check take over.

Notes:
* to be merged after the release 22.2 branch cut
* `blathers/release-justification-check` will pass after `STABILITY_PERIOD`
is turned off [as part of the branch cut playbook]

Release note: None
Release justification: internal-only / non-production
/ release-process code change

----

Release justification:

Co-authored-by: Kyle Patron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants