Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server,ui: show internal stats with new cluster setting #86679

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

maryliag
Copy link
Contributor

Previously, we were not showing internal results on
fingerprint options on SQL Activity.
A new cluster setting created sql.stats.response.show_internal
can be set to true and internal statistics will be
displayed on SQL Activity page.

Fixes #79547

https://www.loom.com/share/1b89ba99a7c247edadb5c8b0d127755c

Release justification: low risk, high benefit change
Release note (sql change): New cluster setting
sql.stats.response.show_internal with default value of false
can be set to true, to display information about internal stats
on SQL Activity page, with fingerprint option.

@maryliag maryliag requested review from rafiss and a team August 23, 2022 17:14
@maryliag maryliag requested a review from a team as a code owner August 23, 2022 17:14
@maryliag maryliag removed request for a team August 23, 2022 17:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, we were not showing internal results on
fingerprint options on SQL Activity.
A new cluster setting created `sql.stats.response.show_internal`
can be set to `true` and internal statistics will be
displayed on SQL Activity page.

Fixes cockroachdb#79547

Release justification: low risk, high benefit change
Release note (sql change): New cluster setting
`sql.stats.response.show_internal` with default value of `false`
can be set to true, to display information about internal stats
on SQL Activity page, with fingerprint option.
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks! what do you think about making the setting default to true? my understanding is that only a small minority of clusters require the queries to be hidden.

@maryliag
Copy link
Contributor Author

@rafiss we received feedback from external customers they wanted this value hidden, and from internal users that they wanted to see this info. It's a lot easier to tell everyone at CRL this cluster setting exists and that you can use to debug, to make the customers having to change the setting to have the behaviour they prefer. For that reason, I'll keep the default as false and share internally about this new cluster setting.

Also, this information can always be accessed through the tables directly, without the need of the UI.

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, sounds good to me. thanks for explaining

@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 23, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 24, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 24, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 24, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 24, 2022

Build failed:

@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 25, 2022

Build succeeded:

@craig craig bot merged commit 54bc65f into cockroachdb:master Aug 25, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 25, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 3750821 to blathers/backport-release-22.1-86679: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: re-enable displaying internal statement in SQL Activity Page
3 participants