Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts: fix the pretty-printing of tsd keys #86563

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

knz
Copy link
Contributor

@knz knz commented Aug 22, 2022

Found while working on #86524.

Release justification: bug fix

Release note (bug fix): When printing keys and range start/end
boundaries for time series, the displayed structure of keys
was incorrect. This is now fixed.

Release justification: bug fix

Release note (bug fix): When printing keys and range start/end
boundaries for time series, the displayed structure of keys
was incorrect. This is now fixed.
@knz knz requested a review from abarganier August 22, 2022 14:08
@knz knz requested a review from a team as a code owner August 22, 2022 14:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz requested a review from andreimatei August 24, 2022 13:16
Copy link
Contributor

@abarganier abarganier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: - thanks for the fix

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)

@knz
Copy link
Contributor Author

knz commented Aug 30, 2022

tfyr

bors r=abarganier

@craig
Copy link
Contributor

craig bot commented Aug 30, 2022

Build succeeded:

@craig craig bot merged commit 716626e into cockroachdb:master Aug 30, 2022
@knz knz deleted the 20220822-ts-display branch August 30, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants