storage: add default-off setting for MVCC range tombstones #86528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
force-pushed
the
mvcc-range-tombstones-setting
branch
from
46aa9cb to
87a9574
Compare
This was referenced Aug 22, 2022
msbutler
approved these changes
Aug 22, 2022
nicktrav
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner and @dt)
erikgrinaker
force-pushed
the
mvcc-range-tombstones-setting
branch
from
87a9574 to
93f682e
Compare
This patch adds the default-off cluster setting `storage.mvcc.range_tombstones.enabled` to control whether or not to write MVCC range tombstones. The setting is internal and system-only. The read path is always active, this only determines whether KV clients should write them. A helper function `CanUseMVCCRangeTombstones()` has also been added. Callers have not yet been updated to respect this. Note that any in-flight jobs may not pick up this change, so these need to be waited out before being certain that the setting has taken effect. If disabled after being enabled, this will prevent new range tombstones from being written, but already written tombstones will remain until GCed. The above note on jobs above also applies in this case. Release justification: bug fixes and low-risk updates to new functionality Release note: None
erikgrinaker
force-pushed
the
mvcc-range-tombstones-setting
branch
from
93f682e to
1809bbe
Compare
|
CI failure appears unrelated (there are no functional changes here anyway). bors r=msbutler,nicktrav |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the default-off cluster setting
storage.mvcc.range_tombstones.enabledto control whether or not towrite MVCC range tombstones. The setting is internal and system-only.
The read path is always active, this only determines whether KV clients
should write them.
A helper function
CanUseMVCCRangeTombstones()has also been added.Callers have not yet been updated to respect this.
Note that any in-flight jobs may not pick up this change, so these need
to be waited out before being certain that the setting has taken effect.
If disabled after being enabled, this will prevent new range tombstones
from being written, but already written tombstones will remain until
GCed. The above note on jobs above also applies in this case.
Release justification: bug fixes and low-risk updates to new functionality
Release note: None