ui: remove next run from jobs that don't have next run #86486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several jobs don't have a future run, so the value being displayed on the Jobs Details page would should the last time it was scheduled. This commit hides the next run field from the page if is not in the future. Fixes cockroachdb#86359 Release justification: low risk, high benefit change Release note (ui change): Remove the Next Planned Execution Time label, when the job doesn't have a next planned execution scheduled.
|
This change is |
ericharmeling
approved these changes
Aug 22, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several jobs don't have a future run, so the value
being displayed on the Jobs Details page would should
the last time it was scheduled.
This commit hides the next run field from the page
if is not in the future.
Fixes #86359
Release justification: low risk, high benefit change
Release note (ui change): Remove the Next Planned Execution
Time label, when the job doesn't have a next planned execution
scheduled.