Correctly prioritize snapshot requests #86456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andrewbaptist
force-pushed
the
correctly-prioritize-snapshot-requests
branch
8 times, most recently
from
4ab03ad to
0109a30
Compare
Previously on both the send and receive snapshot side, the various places that sent snapshots were uncoordinated, and the choice of which snapshot was sent was somewhat arbitrary. This PR uses the new multiqueue to prioritize them correctly. Release note (performance improvement): Snapshots use a fair round-robin approach for choosing which one to send next. Release Justification: A large number of customer support cases have occurred due to incorrect receive side snapshot prioritization. Decommissioning will complete faster with this change. Release justification:
andrewbaptist
force-pushed
the
correctly-prioritize-snapshot-requests
branch
from
0109a30 to
9c338eb
Compare
|
This has been superseded by #86701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kv: Priority sending and receiving snapshots
Previously on both the send and receive snapshot side, the various places that sent snapshots were uncoordinated, and the choice of which snapshot was sent was somewhat arbitrary. Snapshots use a fair round-robin approach for choosing which one to send next. Decommissioning will be considerably faster with this change.
This PR uses the new multiqueue to prioritize them correctly.
Release note (performance improvement): Snapshot starvation for specific types will no longer occur.
Release Justification: A large number of customer support cases have occurred due to incorrect receive side snapshot prioritization. Additionally decommissioning will complete faster after this change.