server: proper transaction state management in sql-over-http #86433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/fix-sql-over-http
branch
3 times, most recently
from
2651443 to
89feebd
Compare
ajwerner
force-pushed
the
ajwerner/fix-sql-over-http
branch
from
89feebd to
bbbab44
Compare
ajwerner
force-pushed
the
ajwerner/fix-sql-over-http
branch
from
bbbab44 to
ce3cb86
Compare
knz
reviewed
Aug 19, 2022
There was a problem hiding this comment.
Last commit LGTM.
I did not review the others.
Reviewed 3 of 3 files at r6, 2 of 2 files at r7, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @stevendanna)
knz
approved these changes
Aug 19, 2022
This is needed both to ensure that the transactions which purposefully use the internal executor can avoid the halloween problem and so that we can use a default QoS level for those transaction. Release justification: part of a bug fix Release note: None
We need to construct the internal executor in the context of the transaction so that we can make sure that its side-effects are properly managed. Without this change, we'd be throwing away all of the extraTxnState between each statement. We'd fail to create the jobs (which we defer to the end of the transaction), and we'd fail to run those jobs and check for errors. We'd also fail to validate the two-version invariant or wait for one version. Fixes cockroachdb#86332 Release justification: Fixes critical bugs in new functionality. Release note: None
ajwerner
force-pushed
the
ajwerner/fix-sql-over-http
branch
from
ce3cb86 to
4812378
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First 4 commits are #86427.
Next commit is #86461.
We need to construct the internal executor in the context of the transaction
so that we can make sure that its side-effects are properly managed. Without
this change, we'd be throwing away all of the extraTxnState between each
statement. We'd fail to create the jobs (which we defer to the end of the
transaction), and we'd fail to run those jobs and check for errors. We'd
also fail to validate the two-version invariant or wait for one version.
Fixes #86332
Release justification: Fixes critical bugs in new functionality.
Release note: None