Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/stats: remove NumRange-stealing behavior from histogram prediction #86348

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

michae2
Copy link
Collaborator

@michae2 michae2 commented Aug 17, 2022

We should be able to handle NumEq=0 just fine everywhere that uses
histograms, so delete this NumRange-stealing code.

Fixes: #86344

Release justification: low-risk updates to new functionality.

Release note: None

We should be able to handle NumEq=0 just fine everywhere that uses
histograms, so delete this NumRange-stealing code.

Fixes: cockroachdb#86344

Release justification: low-risk updates to new functionality.

Release note: None
@michae2 michae2 requested a review from a team as a code owner August 17, 2022 23:17
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it'd probably be good for @rytaft to sign off too.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @cucaroach)

@michae2 michae2 requested a review from rytaft August 18, 2022 00:10
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)

@michae2
Copy link
Collaborator Author

michae2 commented Aug 18, 2022

TFTRs!

bors r=yuzefovich,rytaft

@craig
Copy link
Contributor

craig bot commented Aug 18, 2022

Build succeeded:

@craig craig bot merged commit 5789fac into cockroachdb:master Aug 18, 2022
@michae2 michae2 deleted the numrange branch August 18, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql/stats: remove NumRange-stealing behavior from histogram prediction in forecasts
4 participants