Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scplan: make EXPLAIN target output stable #86318

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

postamar
Copy link
Contributor

This commit does not make any functional changes. It merely ensures that
the diagrams generated by an EXPLAIN (DDL) statement list the schema
change targets in a predefined order: first the to-public targets, then
the transient targets, and finally the to-absent targets.

This helps readability and makes the declarative schema changer
data-driven test output more stable.

Release justification: low-impact, test-only change
Release note: None

This commit does not make any functional changes. It merely ensures that
the diagrams generated by an EXPLAIN (DDL) statement list the schema
change targets in a predefined order: first the to-public targets, then
the transient targets, and finally the to-absent targets.

This helps readability and makes the declarative schema changer
data-driven test output more stable.

Release justification: low-impact, test-only change
Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@postamar postamar marked this pull request as ready for review August 17, 2022 18:10
@postamar postamar requested a review from a team August 17, 2022 18:10
@postamar
Copy link
Contributor Author

Thanks for the review!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 17, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 17, 2022

Build succeeded:

@craig craig bot merged commit 85ae31d into cockroachdb:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants