Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: udf logic tests not to skip dropping databases #86278

Merged

Conversation

chengxiong-ruan
Copy link
Contributor

Now that we support drop functions in legacy schema changer
and declarative schema changer falls back to legacy when seeing
any function descriptor, we can move udf logic tests back
to normal configs.

Release note: None.
Release justification: test only change.

@chengxiong-ruan chengxiong-ruan requested review from ajwerner and a team August 17, 2022 02:42
@chengxiong-ruan chengxiong-ruan requested a review from a team as a code owner August 17, 2022 02:42
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: 🎉

Reviewed 9 of 24 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

@chengxiong-ruan
Copy link
Contributor Author

pkg/sql/opt/exec/execbuilder/tests/fakedist/BUILD.bazel line 12 at r1 (raw file):

        "//pkg/sql/opt/exec/execbuilder:testdata",  # keep
    ],
    shard_count = 2,

dev generate generated this change. My guess is that we were at the edge of some threshold on the number of tests.

@ajwerner
Copy link
Contributor

The shards are min(num_tests_in_config, 16)

@chengxiong-ruan chengxiong-ruan force-pushed the udf-logic-test-not-skipping-drop-db branch from b755c14 to 34ef145 Compare August 17, 2022 03:08
@chengxiong-ruan
Copy link
Contributor Author

The shards are min(num_tests_in_config, 16)

heh. I made a mistake, I should have just used local config for executor tests instead of removing the config from the test file which trigger all these changes :(

@chengxiong-ruan chengxiong-ruan force-pushed the udf-logic-test-not-skipping-drop-db branch from 34ef145 to ca682a2 Compare August 17, 2022 14:20
Now that we support drop functions in legacy schema changer
and declarative schema changer falls back to legacy when seeing
any function descriptor, we can move udf logic tests back
to normal configs.

Release note: None.
Release justification: test only change.
@chengxiong-ruan chengxiong-ruan force-pushed the udf-logic-test-not-skipping-drop-db branch from ca682a2 to 30d124d Compare August 17, 2022 16:29
@chengxiong-ruan
Copy link
Contributor Author

udf expressions are built into new RoutineExprs. For now we need to skip DistSQL for any RoutineExpr before we plumb a function resolver into DistSQL or maybe this todo can be done.

@chengxiong-ruan
Copy link
Contributor Author

TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Aug 17, 2022

Build failed (retrying...):

@craig craig bot merged commit 85ae31d into cockroachdb:master Aug 17, 2022
@craig
Copy link
Contributor

craig bot commented Aug 17, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants