-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: udf logic tests not to skip dropping databases #86278
sql: udf logic tests not to skip dropping databases #86278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 24 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
|
The shards are min(num_tests_in_config, 16) |
b755c14
to
34ef145
Compare
heh. I made a mistake, I should have just used |
34ef145
to
ca682a2
Compare
Now that we support drop functions in legacy schema changer and declarative schema changer falls back to legacy when seeing any function descriptor, we can move udf logic tests back to normal configs. Release note: None. Release justification: test only change.
ca682a2
to
30d124d
Compare
udf expressions are built into new |
TFTR! |
Build failed (retrying...): |
Build succeeded: |
Now that we support drop functions in legacy schema changer
and declarative schema changer falls back to legacy when seeing
any function descriptor, we can move udf logic tests back
to normal configs.
Release note: None.
Release justification: test only change.