sql/parser: add sequence_name_list and view_name_list

[ajwerner]

This will hopefully make for better diagrams.

Fixes #86059

Release justification: docs only change

Release note: None

[cockroach-teamcity]

This change is 

[ajwerner]

I'm not certain that this is an improvement. Maybe it is. Who's our parser guru?

[ajwerner]

What I do not understand is why the view and sequence types get nice list names in their diagrams, but the DROP TABLE statement doesn't.

[ajwerner]

Oh, I figured it out -- it's here

cockroach/pkg/cmd/docgen/diagrams.go

Line 863 in 03170d5

inline: []string{"opt_drop_behavior", "table_name_list"},

I don't know what we want -- should we just not inline table_name_list? Was it nice to inline it? Should I make a list variety for each of the subtypes and then inline all of them? That's probably the most consistent: but also the most ugly.

[ghost]

Oh, I figured it out -- it's here

cockroach/pkg/cmd/docgen/diagrams.go

Line 863 in 03170d5

inline: []string{"opt_drop_behavior", "table_name_list"},

I don't know what we want -- should we just not inline table_name_list? Was it nice to inline it? Should I make a list variety for each of the subtypes and then inline all of them? That's probably the most consistent: but also the most ugly.

Choosing to inline something is at writer discretion. See https://cockroachlabs.atlassian.net/wiki/spaces/ED/pages/1134166645/SQL+Grammar+Documentation#Add-or-update-a-SQL-diagram I don't know why those choices were made, as it was before my time. You can revert that if you feel it's appropriate.

[ajwerner]

I've removed the inlining. Whether this is an improvement, I don't know. I'll let you @stbof decide or advise on further refinement.

[ghost]

I've removed the inlining. Whether this is an improvement, I don't know. I'll let you @stbof decide or advise on further refinement.

I'll build the updated diagrams and see how they look.

[ajwerner]

TFTR!

bors r=stbof

[craig]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)