sql/logictest: attempt to deflake retry errors #86222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we run transactions in logictests, they can be exposed to retry errors. The framework does not have tools to retry whole blocks. In cockroachdb#58217 we added a mechanism to skip tests which hit such errors. Apply that logic here. (hopefully) Fixes cockroachdb#86215 Release note: None
|
This change is |
chengxiong-ruan
approved these changes
Aug 16, 2022
|
TFTR! bors r+ |
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run transactions in logictests, they can be exposed to retry errors.
The framework does not have tools to retry whole blocks. In #58217 we added
a mechanism to skip tests which hit such errors. Apply that logic here.
(hopefully)
Fixes #86215
Release justification: testing only change
Release note: None