sql: do not distribute queries with subqueries returning OIDs #86186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
force-pushed
the
subquery-doid
branch
from
11e7c49 to
0a48adb
Compare
cucaroach
reviewed
Aug 17, 2022
pkg/sql/distsql_physical_planner.go
Outdated
| @@ -273,6 +273,16 @@ func (v *distSQLExprCheckVisitor) VisitPre(expr tree.Expr) (recurse bool, newExp | |||
| case *tree.DOid: | |||
| v.err = newQueryNotSupportedError("OID expressions are not supported by distsql") | |||
| return false, expr | |||
| case *tree.Subquery: | |||
| if t.ResolvedType().Family() == types.OidFamily { | |||
There was a problem hiding this comment.
What if t is an array or tuple containing an OID?
yuzefovich
force-pushed
the
subquery-doid
branch
from
0a48adb to
7a8f21e
Compare
yuzefovich
commented
Aug 17, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @cucaroach and @mgartner)
pkg/sql/distsql_physical_planner.go line 277 at r1 (raw file):
Previously, cucaroach (Tommy Reilly) wrote…
What if t is an array or tuple containing an OID?
Good point - it would still be a problem. Fixed.
yuzefovich
force-pushed
the
subquery-doid
branch
from
7a8f21e to
58b8613
Compare
If a subquery results in a DOid datum, the datum will get a type annotation (because DOids are ambiguous) when serializing the render expression involving the result of the subquery. As a result, we might need to perform a cast on a remote node which might fail, thus we prohibit the distribution of the main query. Release justification: bug fix. Release note: None
yuzefovich
force-pushed
the
subquery-doid
branch
from
58b8613 to
0643813
Compare
mgartner
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Thanks!
Reviewed 1 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:
|
TFTRs! bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a subquery results in a DOid datum, the datum will get a type
annotation (because DOids are ambiguous) when serializing the
render expression involving the result of the subquery. As a
result, we might need to perform a cast on a remote node which
might fail, thus we prohibit the distribution of the main query.
Fixes: #86075.
Release justification: bug fix.
Release note: None