-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: omit MVCCIterator.Stats()
call during MVCCScan
/MVCCGet
#86084
storage: omit MVCCIterator.Stats()
call during MVCCScan
/MVCCGet
#86084
Conversation
c62395a
to
79aec18
Compare
`MVCCScan` and `MVCCGet` attach iterator statistics to an active trace. However, they would fetch the iterator statistics even if no trace was active, which has a significant cost. This patch avoids fetching the stats when there is no active trace. ``` name old time/op new time/op delta MVCCGet_Pebble/batch=true/versions=1/valueSize=8/numRangeKeys=0-24 3.59µs ± 0% 3.34µs ± 0% -7.02% (p=0.000 n=10+8) MVCCGet_Pebble/batch=true/versions=1/valueSize=8/numRangeKeys=1-24 7.43µs ± 1% 7.01µs ± 0% -5.70% (p=0.000 n=10+9) MVCCGet_Pebble/batch=true/versions=10/valueSize=8/numRangeKeys=0-24 4.62µs ± 1% 4.36µs ± 1% -5.53% (p=0.000 n=10+10) MVCCGet_Pebble/batch=true/versions=10/valueSize=8/numRangeKeys=1-24 10.4µs ± 1% 10.0µs ± 1% -3.79% (p=0.000 n=10+10) ``` Release note: None
79aec18
to
c739468
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @jbowens)
TFTR! bors r=nicktrav |
Build failed (retrying...): |
Build failed (retrying...): |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from c739468 to blathers/backport-release-21.2-86084: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. error creating merge commit from c739468 to blathers/backport-release-22.1-86084: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
MVCCScan
andMVCCGet
attach iterator statistics to an active trace.However, they would fetch the iterator statistics even if no trace was
active, which has a significant cost. This patch avoids fetching the
stats when there is no active trace.
Resolves #86083.
Touches #64503.
Release note: None