Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: publish cockroach-sql as an archive #86051

Merged
merged 1 commit into from
Aug 13, 2022
Merged

build: publish cockroach-sql as an archive #86051

merged 1 commit into from
Aug 13, 2022

Conversation

rail
Copy link
Member

@rail rail commented Aug 12, 2022

Previously, cockroach-sql was published as a standalone binary on S3.

This made the UX cumbersome for end-users:

  • we provide explanations in docs about how to extract archives, and this is not an archive
  • on macos and linux, the user needs to still run chmod +x on the result, and we didn't document that

This PR packages the cockroach-sql binary as a tarball/zip file and
generates its SH256 checksum.

Fixes #81246

Release note: None

@rail
build: publish cockroach-sql as an archive
5005df8 
Previously, cockroach-sql was published as a standalone binary on S3.

This made the UX cumbersome for end-users:
* we provide explanations in docs about how to extract archives, and this is not an archive
* on macos and linux, the user needs to still run chmod +x on the result, and we didn't document that

This PR packages the `cockroach-sql` binary as a tarball/zip file and
generates its SH256 checksum.

Fixes cockroachdb#81246

Release note: None
@rail rail added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-release T-release Release Engineering & Automation Team labels Aug 12, 2022
@rail rail self-assigned this Aug 12, 2022
@rail rail requested a review from a team as a code owner August 12, 2022 18:00
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail
Copy link
Member Author

rail commented Aug 12, 2022

So far it's looking good. My custom build generated these:

  1. https://storage.googleapis.com/cockroach-builds-artifacts-prod/cockroach-sql-v22.2.0-alpha.00000000-2521-g5005df8591.darwin-10.9-amd64.tgz
  2. https://storage.googleapis.com/cockroach-builds-artifacts-prod/cockroach-sql-v22.2.0-alpha.00000000-2521-g5005df8591.darwin-10.9-amd64.tgz.sha256sum
  3. https://storage.googleapis.com/cockroach-builds-artifacts-prod/cockroach-sql-v22.2.0-alpha.00000000-2521-g5005df8591.linux-amd64.tgz
  4. https://storage.googleapis.com/cockroach-builds-artifacts-prod/cockroach-sql-v22.2.0-alpha.00000000-2521-g5005df8591.linux-amd64.tgz.sha256sum
  5. https://storage.googleapis.com/cockroach-builds-artifacts-prod/cockroach-sql-v22.2.0-alpha.00000000-2521-g5005df8591.windows-6.2-amd64.zip
  6. https://storage.googleapis.com/cockroach-builds-artifacts-prod/cockroach-sql-v22.2.0-alpha.00000000-2521-g5005df8591.windows-6.2-amd64.zip.sha256sum

@rail rail requested a review from rickystewart August 12, 2022 18:52
rickystewart
rickystewart approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@rickystewart rickystewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@rail
Copy link
Member Author

rail commented Aug 12, 2022

bors r=rickystewart

@craig
Copy link
Contributor

craig bot commented Aug 13, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 13, 2022

Build succeeded:

@craig craig bot merged commit c1b8cbc into cockroachdb:master Aug 13, 2022
@knz
Copy link
Contributor

knz commented Aug 13, 2022

This is cool, thanks.

Is there a way to issue (possibly manually) archives for the previous 22.1 releases too? This way we could update all the docs links to have a single guide to extract them.

@knz knz mentioned this pull request Aug 13, 2022
Closed
@rail
Copy link
Member Author

rail commented Aug 13, 2022

This is cool, thanks.

Is there a way to issue (possibly manually) archives for the previous 22.1 releases too? This way we could update all the docs links to have a single guide to extract them.

I want to do this to simplify everyone's life. Backporting this PR may need some manual intervention.

@rail rail mentioned this pull request Aug 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickystewart rickystewart rickystewart approved these changes

Assignees

@rail rail

Labels
A-release C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-release Release Engineering & Automation Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build: publish cockroach-sql as an archive, not a standalone binary
4 participants
@rail @cockroach-teamcity @knz @rickystewart