kvserver: record paused replica message drops to a metric #86039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pav-kv
force-pushed
the
replica_messages_dropped_counter
branch
2 times, most recently
from
89a0931 to
c8aae3f
Compare
|
@tbg I think we may also want to check this counter in tests? |
pav-kv
force-pushed
the
replica_messages_dropped_counter
branch
from
c8aae3f to
07297ae
Compare
pav-kv
commented
Aug 12, 2022
pav-kv
force-pushed
the
replica_messages_dropped_counter
branch
from
07297ae to
4190953
Compare
|
PTAL |
|
bors r=tbg |
|
Build failed: |
|
bors retry |
|
Build failed (retrying...): |
|
Build failed: |
|
No luck today :) |
|
bors retry |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
Release note: None
pav-kv
force-pushed
the
replica_messages_dropped_counter
branch
from
4190953 to
0bd35fb
Compare
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #83917
Release justification: The metric may help investigating issues with paused replicas
Release note: None