sql: don't panic on auth check with unopen txn #85996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever since c00ea84 was merged, the KV layer has disallowed use of an aborted txn. Therefore, the checks here are no longer necessary. This should actually help with debugging, since now if the aborted txn is used, we should get back an error that has the reason for the abort (or restart), instead of a panic that does not have that info. Release note: None
|
This change is |
RichardJCai
approved these changes
Aug 11, 2022
ajwerner
approved these changes
Aug 11, 2022
|
tftrs! bors r=ajwerner,RichardJCai |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #80764 and #82034
Ever since c00ea84 was merged, the KV
layer has disallowed use of an aborted txn. Therefore, the checks here
are no longer necessary.
This should actually help with debugging, since now if the aborted txn
is used, we should get back an error that has the reason for the abort
(or restart), instead of a panic that does not have that info.
Release note: None