ui: new insights table component #85862
Conversation
|
This change is |
maryliag
force-pushed
the
insight-component
branch
5 times, most recently
from
3ff18e8 to
1f02f38
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @maryliag and @THardy98)
pkg/ui/workspaces/cluster-ui/src/indexRecommendationsTable/indexRecommendationsTable.tsx line 31 at r1 (raw file):
} export class IdxInsightsSortedTable extends SortedTable<IdxRecommendation> {}
I see on the figma (https://www.figma.com/file/xpnRkP9cLXERVceRC4cec4/22.2_SQL-obsrv_query-performance?node-id=301%3A3805) there could be schema insights unrelated to index recs like Outdated Table Statistics, despite that, are we we okay with keeping this table as "Index Insights" ?
pkg/ui/workspaces/cluster-ui/src/indexRecommendationsTable/indexRecommendationsTable.tsx line 73 at r1 (raw file):
return "Create New Index"; case "DROP": return "Drop Index";
I think should be Drop Unused Index, currently that's the only index recommendation we recommend for index drops.
Creation of the base insights table, that can be used on both schema insights and statement details page. This commit only introduce the table, with the different types, but still needs the proper cell formating for each type. Part of cockroachdb#83783 Release note: None
maryliag
force-pushed
the
insight-component
branch
from
1f02f38 to
7f023c2
Compare
maryliag
changed the title
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/indexRecommendationsTable/indexRecommendationsTable.tsx line 31 at r1 (raw file):
Previously, THardy98 (Thomas Hardy) wrote…
I see on the figma (https://www.figma.com/file/xpnRkP9cLXERVceRC4cec4/22.2_SQL-obsrv_query-performance?node-id=301%3A3805) there could be schema insights unrelated to index recs like
Outdated Table Statistics, despite that, are we we okay with keeping this table as "Index Insights" ?
Renamed
pkg/ui/workspaces/cluster-ui/src/indexRecommendationsTable/indexRecommendationsTable.tsx line 73 at r1 (raw file):
Previously, THardy98 (Thomas Hardy) wrote…
I think should be
Drop Unused Index, currently that's the only index recommendation we recommend for index drops.
Done
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Creation of the base insights table,
that can be used on both schema insights and statement
details page.
This commit only introduce the table, with the different
types, but still needs the proper cell formating for
each type.
Part of #83783
Release note: None