Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: replace Raft transport stats with metrics #85767

Closed
wants to merge 1 commit into from

Conversation

pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Aug 8, 2022

RaftTransport computes ad-hoc stats on sending and receiving messages, and
prints them to log. This is inconvenient to match with other metrics when
doing forensics. This commit changes the stats to be proper metrics exported by
the server.

Part of #83917.

Release note: None

@pav-kv pav-kv requested a review from tbg August 8, 2022 20:04
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pav-kv
Copy link
Collaborator Author

pav-kv commented Aug 8, 2022

This is a draft still. A few things to do:

  • Consider adding the connection class label.
  • Have the metrics recorded (somewhere in server/status/recorder.go).

@pav-kv pav-kv force-pushed the raft_transport_metrics branch 2 times, most recently from 96e1baa to a960798 Compare August 8, 2022 20:29
RaftTransport computes ad-hoc stats on sending and receiving messages, and
prints them to log. This is inconvenient to match with other metrics when
doing forensics. This commit changes the stats to be proper metrics exported by
the server.

Release note: None
@pav-kv pav-kv force-pushed the raft_transport_metrics branch from a960798 to 5364b47 Compare August 9, 2022 12:58
@tbg tbg removed their request for review August 10, 2022 15:42
@pav-kv
Copy link
Collaborator Author

pav-kv commented Aug 11, 2022

Obsoleted by #85951

@pav-kv pav-kv closed this Aug 11, 2022
@pav-kv pav-kv deleted the raft_transport_metrics branch August 11, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants