Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: add strptime/strftime builtins without experimental prefix #85756

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 8, 2022

refs #52139

These are just an alias for the existing implementation.

Release note (sql change): The strptime and strftime builtin functions
were added as aliases for experimental_strptime and
experimental_strftime.

@rafiss rafiss requested review from RichardJCai and a team August 8, 2022 17:19
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss force-pushed the remove-experimental-func branch 2 times, most recently from 11f7dc9 to ca0763c Compare August 9, 2022 15:12
These are just an alias for the existing implementation.

Release note (sql change): The strptime and strftime builtin functions
were added as aliases for experimental_strptime and
experimental_strftime.
@rafiss rafiss force-pushed the remove-experimental-func branch from ca0763c to dfc6123 Compare August 9, 2022 15:40
@rafiss
Copy link
Collaborator Author

rafiss commented Aug 10, 2022

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 10, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 10, 2022

Build succeeded:

@craig craig bot merged commit 9be7cf5 into cockroachdb:master Aug 10, 2022
@rafiss rafiss deleted the remove-experimental-func branch August 10, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants