Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: version gating CREATE FUNCTION #85744

Merged

Conversation

chengxiong-ruan
Copy link
Contributor

This commit adds a version gate for CREATE FUNCTION statement.

Release note: None.

@chengxiong-ruan chengxiong-ruan marked this pull request as ready for review August 8, 2022 14:37
@chengxiong-ruan chengxiong-ruan requested a review from a team August 8, 2022 14:37
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@chengxiong-ruan chengxiong-ruan force-pushed the udf-version-gate-create-function branch 2 times, most recently from 19b4571 to c3dbf34 Compare August 8, 2022 23:07
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 6 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

@chengxiong-ruan chengxiong-ruan force-pushed the udf-version-gate-create-function branch from c3dbf34 to bde472e Compare August 9, 2022 17:58
@chengxiong-ruan
Copy link
Contributor Author

TFTR!
bors r+

@chengxiong-ruan
Copy link
Contributor Author

conflicting with myself looks like :(
bors r-

@craig
Copy link
Contributor

craig bot commented Aug 9, 2022

Canceled.

This commit adds a version gate for `CREATE FUNCTION` statement.

Release note: None.
@chengxiong-ruan chengxiong-ruan force-pushed the udf-version-gate-create-function branch from bde472e to 6aa98b2 Compare August 10, 2022 04:03
@chengxiong-ruan
Copy link
Contributor Author

TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Aug 10, 2022

Build succeeded:

@craig craig bot merged commit 65fe1a5 into cockroachdb:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants