Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: sql: add join types and algorithms to telemetry logging #85743

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

rytaft
Copy link
Collaborator

@rytaft rytaft commented Aug 8, 2022

Backport 1/1 commits from #85524.

/cc @cockroachdb/release


This commit adds several new fields to the SampledQuery structure used for
telemetry logging.

Closes #85425

Release note (sql change): The structured payloads used for telemetry
logs now include the following new fields:
InnerJoinCount: The number of inner joins in the query plan.
LeftOuterJoinCount: The number of left (or right) outer joins in the query
plan.
FullOuterJoinCount: The number of full outer joins in the query plan.
SemiJoinCount: The number of semi joins in the query plan.
AntiJoinCount: The number of anti joins in the query plan.
IntersectAllJoinCount: The number of intersect all joins in the query plan.
ExceptAllJoinCount: The number of except all joins in the query plan.
HashJoinCount: The number of hash joins in the query plan.
CrossJoinCount: The number of cross joins in the query plan.
IndexJoinCount: The number of index joins in the query plan.
LookupJoinCount: The number of lookup joins in the query plan.
MergeJoinCount: The number of merge joins in the query plan.
InvertedJoinCount: The number of inverted joins in the query plan.
ApplyJoinCount: The number of apply joins in the query plan.
ZigZagJoinCount: The number of zig zag joins in the query plan.


Release justification: Low risk telemetry change

This commit adds several new fields to the SampledQuery structure used for
telemetry logging.

Closes cockroachdb#85425

Release note (sql change): The structured payloads used for telemetry
logs now include the following new fields:
`InnerJoinCount`: The number of inner joins in the query plan.
`LeftOuterJoinCount`: The number of left (or right) outer joins in the query
plan.
`FullOuterJoinCount`: The number of full outer joins in the query plan.
`SemiJoinCount`: The number of semi joins in the query plan.
`AntiJoinCount`: The number of anti joins in the query plan.
`IntersectAllJoinCount`: The number of intersect all joins in the query plan.
`ExceptAllJoinCount`: The number of except all joins in the query plan.
`HashJoinCount`: The number of hash joins in the query plan.
`CrossJoinCount`: The number of cross joins in the query plan.
`IndexJoinCount`: The number of index joins in the query plan.
`LookupJoinCount`: The number of lookup joins in the query plan.
`MergeJoinCount`: The number of merge joins in the query plan.
`InvertedJoinCount`: The number of inverted joins in the query plan.
`ApplyJoinCount`: The number of apply joins in the query plan.
`ZigZagJoinCount`: The number of zig zag joins in the query plan.
@rytaft rytaft requested review from yuzefovich, THardy98 and a team August 8, 2022 14:26
@rytaft rytaft requested review from a team as code owners August 8, 2022 14:26
@blathers-crl
Copy link

blathers-crl bot commented Aug 8, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @THardy98)

@rytaft rytaft merged commit cb98eb7 into cockroachdb:release-22.1 Aug 8, 2022
@rytaft rytaft deleted the backport22.1-85524 branch August 8, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants