Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colexec: reorder some fields to reduce memory footprint #85684

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

yuzefovich
Copy link
Member

This commit applies some of the fixes found by the fieldalignment tool
on the colexec packages which reorder some fields in the structs so that
the memory footprint is reduced.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich marked this pull request as ready for review August 5, 2022 21:40
@yuzefovich yuzefovich requested a review from a team as a code owner August 5, 2022 21:40
@yuzefovich yuzefovich requested review from michae2 and msirek August 5, 2022 21:40
Copy link
Contributor

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @michae2)

This commit applies some of the fixes found by the `fieldalignment` tool
on the colexec packages which reorder some fields in the structs so that
the memory footprint is reduced.

Release note: None
@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig craig bot merged commit d58473e into cockroachdb:master Aug 8, 2022
@craig
Copy link
Contributor

craig bot commented Aug 8, 2022

Build succeeded:

@yuzefovich yuzefovich deleted the fieldalignment branch August 8, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants