Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: add MVCC range stats to Db Console #85599

Merged
merged 1 commit into from
Aug 4, 2022
Merged

ui: add MVCC range stats to Db Console #85599

merged 1 commit into from
Aug 4, 2022

Conversation

koorosh
Copy link
Collaborator

@koorosh koorosh commented Aug 4, 2022

This patch extends node details with rangeKeyBytes
and rangeValueBytes stats. Also, it adds the same
stats to Advanced Debug > Range Status section.

Release note (ui change): Added "Range Key Bytes" and
"Range Value Bytes" stats on Node details page.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@koorosh koorosh requested review from erikgrinaker and a team August 4, 2022 07:16
erikgrinaker
erikgrinaker approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a high level. This will handle missing fields from 22.1 nodes gracefully?

pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeOverview/tooltips.tsx Outdated Show resolved Hide resolved
@koorosh koorosh force-pushed the ui-add-mvcc-range-key-val-stats branch from 50ffd28 to 064ce59 Compare August 4, 2022 11:50
@koorosh
Copy link
Collaborator Author

koorosh commented Aug 4, 2022

LGTM at a high level. This will handle missing fields from 22.1 nodes gracefully?

Changed access to fields with fallback values in case they're not available for any reason.

Regarding version 22.1, this version serves it's own version of DbConsole that doesn't have this change (unless it is not backported) and relies on protobuf definitions without new stats.
If user accesses DbConsole from 22.2 version, then it still have this field in proto message with null value for missing data. This case should be handled by added change with fallback values.

@erikgrinaker
Copy link
Contributor

Makes sense, thanks! Wasn't sure if DB Console would receive data from other nodes -- if it only ever communicates with the local node then it should be fine. But good to have a fallback just in case.

Thanks again for getting this in so quickly!

@koorosh
ui: add MVCC range stats to Db Console
154faa6 
This patch extends node details with `rangeKeyBytes`
and `rangeValueBytes` stats. Also, it adds the same
stats to Advanced Debug > Range Status section.

Release note (ui change): Added "Range Key Bytes" and
"Range Value Bytes" stats on Node details page.
@koorosh koorosh force-pushed the ui-add-mvcc-range-key-val-stats branch from 064ce59 to 154faa6 Compare August 4, 2022 15:10
@koorosh
Copy link
Collaborator Author

koorosh commented Aug 4, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 4, 2022

Build succeeded:

@craig craig bot merged commit 60c3679 into cockroachdb:master Aug 4, 2022
@cockroach-teamcity cockroach-teamcity mentioned this pull request Aug 4, 2022
Closed
@erikgrinaker erikgrinaker mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker erikgrinaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koorosh @cockroach-teamcity @erikgrinaker