cloud: add stream INTERNAL_ERROR to resumable HTTP errors #85538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
running some roachtests on this branch now |
|
Just noting that this is also used in s3 and httpstorage, I think that's fine cause this is a lower level HTTP internal error. LGTM once you're happy with the roachtests, might be worth running against s3 too. |
adityamaru
approved these changes
Aug 3, 2022
Currently, errors like `stream error: stream ID <x>; INTERNAL_ERROR; received from peer` are not being retried. Retry these errors assuggested by: googleapis/google-cloud-go#3735 googleapis/google-cloud-go#784 Fixes: cockroachdb#85217, cockroachdb#85216, cockroachdb#85204, cockroachdb#84162 Release note: None
|
22.1 unsupported now, targeted fix was in #85024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, errors like
stream error: stream ID <x>; INTERNAL_ERROR; received from peerare not being retried. Retry these errors assuggested by:
googleapis/google-cloud-go#3735
googleapis/google-cloud-go#784
Fixes: #85217, #85216, #85204, #84162
Release note: None