Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: remove support for pre-22.1 backups #85536

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

dt
Copy link
Member

@dt dt commented Aug 3, 2022

Release note: none.

@dt dt requested review from benbardin, adityamaru and a team August 3, 2022 14:39
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@benbardin benbardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: perhaps rename the commit? "migrations" implies something db-level to me. Perhaps "backupccl: remove support for pre-22.1 backups"?

@dt dt changed the title backupccl: delete per-22.1 migrations backupccl: delete pre-22.1 migrations Aug 3, 2022
@dt dt changed the title backupccl: delete pre-22.1 migrations backupccl: remove support for pre-22.1 backups Aug 3, 2022
@dt
Copy link
Member Author

dt commented Aug 3, 2022

rename

done.

backstory: "migrations" is what we called cluster versions -- specifically the functions that advance them but also the overall process of advancing though versions. We've since renamed the in-code packages from "migrations" to "upgrades" when we formed a new team called "migrations" which was working on migrations of workloads to cockroach, rather than version migrations, and are trying to curtail the old usage, so thanks for catching.

@dt
Copy link
Member Author

dt commented Aug 3, 2022

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 3, 2022

Build succeeded:

@craig craig bot merged commit 9650b0d into cockroachdb:master Aug 3, 2022
@dt dt deleted the backup-vers branch August 3, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants