Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowinfra: preserve flowRetryableError correctly across network #85500

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

yuzefovich
Copy link
Member

This commit makes it so that flowinfra.flowRetryableError type is
correctly preserved across network. Previously, if the error originated
on the remote node, the coordinator node would receive
errbase.opaqueLeaf error since the decoder method wasn't registered
for the error, now the error is preserved correctly.

Release note: None

@yuzefovich yuzefovich requested review from miretskiy and a team August 3, 2022 01:48
@yuzefovich yuzefovich requested a review from a team as a code owner August 3, 2022 01:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich
Copy link
Member Author

I found this when working on #82752, here is how the error looks during TestChangefeedHandlesDrainingNodes:
Screen Shot 2022-08-02 at 6 45 53 PM

This commit makes it so that `flowinfra.flowRetryableError` type is
correctly preserved across network. Previously, if the error originated
on the remote node, the coordinator node would receive
`errbase.opaqueLeaf` error since the decoder method wasn't registered
for the error, now the error is preserved correctly.

Release note: None
@yuzefovich yuzefovich force-pushed the flow-retryable-error branch from a005834 to 91acca3 Compare August 3, 2022 15:59
@yuzefovich
Copy link
Member Author

Fixed the linter.

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 3, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 3, 2022

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Aug 3, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 91acca3 to blathers/backport-release-21.2-85500: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants