cloud/amazon: add toggle for s3 storage to list prefix with additiona… #85493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
approved these changes
Aug 12, 2022
| @@ -622,8 +623,15 @@ func (s *s3Storage) List(ctx context.Context, prefix, delim string, fn cloud.Lis | |||
| return true | |||
| } | |||
|
|
|||
| var s3Input *s3.ListObjectsInput | |||
There was a problem hiding this comment.
nit: can you copy your comment in the commit into the code as well? It'll be useful to understand why we have this special case whenever someone reads this file
…l marker Add toggle for s3 storage to list prefixes with a paging marker that's the prefix with an additional `/`. This allows certain s3 clones which return `s3://<prefix>/` as the first result of listing `s3://<prefix>` to exclude that result. This behavior is toggled via setting the environment variable `COCKROACH_S3_LIST_WITH_PREFIX_SLASH_MARKER` to true. Release note: None
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l marker
Add toggle for s3 storage to list prefixes with a paging marker that's the
prefix with an additional
/. This allows certain s3 clones which returns3://<prefix>/as the first result of listings3://<prefix>to exclude thatresult.
This behavior is toggled via setting the environment variable
COCKROACH_S3_LIST_WITH_PREFIX_SLASH_MARKERto true.Release note: None