release-22.1: sql, telemetry: show correctly redacted error message #85403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #83807 on behalf of @dhartunian.
/cc @cockroachdb/release
Previously, the error string from an executed SQL statement was treated
as a
string
type which would get fully redacted on its way out to thetelemetry log.
This change writes the
error
type into aRedactableString
whichpreserves the redaction in the error as intended. This will preserve the
template string which we consider safe by default, for instance.
The
CommonSQLExecDetails
type insql_audit_events.proto
has beenmodified to have the
error_text
field represented as aRedactableString
which helps us maintain the preservation of redactionmarkers.
Resolves: #78353
Release note (ops change): Telemetry logs will now display more finely
redacted error messages from sql execution. Previously, the entire error
string was fully redacted.
Release justification: low-risk logging-only change that improves telemetry.