Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix udf logic test #85327

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Conversation

chengxiong-ruan
Copy link
Contributor

Fixes: #85303

Release note: None

Fixes: cockroachdb#85303

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

@chengxiong-ruan
Copy link
Contributor Author

TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Jul 29, 2022

Build succeeded:

@craig craig bot merged commit 7e2df69 into cockroachdb:master Jul 29, 2022
@adityamaru
Copy link
Contributor

Seeing a different flake in this test - https://teamcity.cockroachdb.com/viewLog.html?buildId=6011909&buildTypeId=Cockroach_BazelEssentialCi

Looks like the OIDs are unstable @chengxiong-ruan?

@ajwerner
Copy link
Contributor

ajwerner commented Aug 8, 2022

I had hoped that the OIDs would become more stable after #85366.
@chengxiong-ruan how do you feel about projecting out the OID column for now?

@ajwerner
Copy link
Contributor

ajwerner commented Aug 8, 2022

Oh nice, they are stable, just needed a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/sql/logictest/tests/local-vec-off/local-vec-off_test: TestLogic_udf failed
5 participants