Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: fix tests to not use go get #85088

Merged
merged 1 commit into from
Jul 27, 2022
Merged

roachtest: fix tests to not use go get #85088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/gopg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ func registerGopg(r registry.Registry) {
// We pipe the test output into go-junit-report tool which will output
// it in XML format.
fmt.Sprintf(`cd %s &&
GOPATH=%s go get -u github.com/jstemmer/go-junit-report &&
GOPATH=%s go install github.com/jstemmer/go-junit-report@latest &&
cat %s | %s/bin/go-junit-report`,
destPath, goPath, resultsFilePath, goPath),
)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/gorm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func registerGORM(r registry.Registry) {
// Install go-junit-report to convert test results to .xml format we know
// how to work with.
if err := repeatRunE(
ctx, t, c, node, "install go-junit-report", fmt.Sprintf("GOPATH=%s go get -u github.com/jstemmer/go-junit-report", goPath),
ctx, t, c, node, "install go-junit-report", fmt.Sprintf("GOPATH=%s go install github.com/jstemmer/go-junit-report@latest", goPath),
); err != nil {
t.Fatal(err)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/libpq.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func registerLibPQ(r registry.Registry) {
// Install go-junit-report to convert test results to .xml format we know
// how to work with.
err = repeatRunE(ctx, t, c, node, "install go-junit-report",
fmt.Sprintf("GOPATH=%s go get -u github.com/jstemmer/go-junit-report", goPath),
fmt.Sprintf("GOPATH=%s go install github.com/jstemmer/go-junit-report@latest", goPath),
)
require.NoError(t, err)

Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/pgx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func registerPgx(r registry.Registry) {

t.Status("installing go-junit-report")
if err := repeatRunE(
ctx, t, c, node, "install go-junit-report", "go get -u github.com/jstemmer/go-junit-report",
ctx, t, c, node, "install go-junit-report", "go install github.com/jstemmer/go-junit-report@latest",
); err != nil {
t.Fatal(err)
}
Expand Down