Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval: stop ignoring all ResolveOIDFromOID errors #85086

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Jul 26, 2022

fixes #84448

The decision about whether an error is safe to ignore is made at the
place where the error is created/returned. This way, the callers don't
need to be aware of any new error codes that the implementation may
start returning in the future.

Release note (bug fix): Fixed incorrect error handling that could cause
casts to OID types to fail in some cases.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

The decision about whether an error is safe to ignore is made at the
place where the error is created/returned. This way, the callers don't
need to be aware of any new error codes that the implementation may
start returning in the future.

Release note (bug fix): Fixed incorrect error handling that could cause
casts to OID types to fail in some cases.
@rafiss rafiss force-pushed the fix-resolve-oid-err branch from 6956a2b to 6817eb6 Compare July 26, 2022 21:59
@rafiss rafiss requested review from a team, ajwerner and fqazi July 26, 2022 21:59
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing it!

@rafiss
Copy link
Collaborator Author

rafiss commented Jul 27, 2022

tftr!

bors r=ajwerner

@craig
Copy link
Contributor

craig bot commented Jul 27, 2022

Build succeeded:

@craig craig bot merged commit 811ca1f into cockroachdb:master Jul 27, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jul 27, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 6817eb6 to blathers/backport-release-21.2-85086: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


error creating merge commit from 6817eb6 to blathers/backport-release-22.1-85086: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: errors from ResolveOIDFromOID are ignored
3 participants