logictest: remove spec-planning configs #85042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes `local-spec-planning`, `fakedist-spec-planning`, and `5node-spec-planning` logic test configurations since they seem to be not very useful at the moment. They were introduced to support the new DistSQL spec factory, but that work has been postponed with no active development at the moment, so it seems silly to run most of the logic tests through the configs that are largely duplicate of the other default ones (because most of the `Construct*` methods are not implemented in the new factory). Once the active development on the new factory resumes, it'll be pretty easy to bring them back to life, but at the moment let's reduce the amount of tests we run without really losing any test coverage. Release note: None
|
This change is |
mgartner
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes
local-spec-planning,fakedist-spec-planning, and5node-spec-planninglogic test configurations since they seem to benot very useful at the moment. They were introduced to support the new
DistSQL spec factory, but that work has been postponed with no active
development at the moment, so it seems silly to run most of the logic
tests through the configs that are largely duplicate of the other
default ones (because most of the
Construct*methods are notimplemented in the new factory). Once the active development on the new
factory resumes, it'll be pretty easy to bring them back to life, but at
the moment let's reduce the amount of tests we run without really losing
any test coverage.
Release note: None