release-22.1: release-22.1: colexec: fixed nullableArgs projection operators #84966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
This commit changed some comments in `proj_const_ops_tmpl.go` and `proj_non_const_ops_tmpl.go` to become template-time only. Release note: none
Previously, the `Concat` projection operators on arrays directly copy nulls into the output without performing the actual projection whenever either argument was null. This is incorrect because `Concat` operator can actually handle null arguments, and we want the actual projection result instead. Since currently the only projection operator that needs `nullableArgs == true` behaviour is `ConcatDatumDatum`, this PR fixed this by adding a boolean field `nullableArgs` to the logic for operators with `Datum`, `Datum`. If we later introduce another projection operation that has nullableArgs == true, we should update this code accordingly. Fixes: #83091 Release note (bug fix): Fixed a bug in `Concat` projection operators on arrays that gave output of nulls when the projection operator can actually handle null arguments and may result in a non-null output.
blathers-crl
bot
force-pushed
the
blathers/backport-release-22.1-84615
branch
from
5f29dac to
4be41cb
Compare
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
blathers-backport
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #84615 on behalf of @wenyihu6.
/cc @cockroachdb/release
Backport 2/2 commits from #84159.
/cc @cockroachdb/release
Previously, the
Concatprojection operators on arrays directly copy nulls intothe output without performing the actual projection whenever either argument was
null. This is incorrect because
Concatoperator can actually handle null arguments,and we want the actual projection result instead. Since currently the only
projection operator that needs
nullableArgs == truebehaviour isConcatDatumDatum, this PR fixed this by adding a boolean fieldnullableArgsto the logic for operators with
Datum,Datum. If we later introduce anotherprojection operation that has nullableArgs == true, we should update this code
accordingly.
Fixes: #83091
Release note (bug fix): Fixed a bug in
Concatprojection operators on arraysthat gave output of nulls when the projection operator can actually handle null
arguments and may result in a non-null output.
Release justification: bug fix
Release justification: