-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: set up eslint-plugin-crdb for db-console #84856
ui: set up eslint-plugin-crdb for db-console #84856
Conversation
When the custom eslint-plugin-crdb was added to this repo [1], it was accidentally only configured in the cluster-ui subproject. Add eslint-plugin-crdb to the db-console subproject, fixing a lint failure in the process. [1] ba68179 (ui: use esbuild-loader in webpack configs, 2022-05-26) Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @maryliag and @sjbarag)
pkg/ui/workspaces/db-console/src/views/tracez/tracez.tsx
line 41 at r1 (raw file):
import { CaretRight } from "@cockroachlabs/icons"; import { Switch } from "antd"; import "antd/lib/switch/style";
where is this being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
pkg/ui/workspaces/db-console/src/views/tracez/tracez.tsx
line 41 at r1 (raw file):
Previously, maryliag (Marylia Gutierrez) wrote…
where is this being used?
Technically nowhere, but the import is required to make sure the <Switch/>
component gets the correct styling. We used to use https://github.com/umijs/babel-plugin-import to include this import at build-time, but the move to esbuild-loader
meant we can't use a babel plugin. The eslint plugin is there to make sure we do this manually :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @maryliag and @sjbarag)
pkg/ui/workspaces/db-console/src/views/tracez/tracez.tsx
line 41 at r1 (raw file):
Previously, sjbarag (Sean Barag) wrote…
Technically nowhere, but the import is required to make sure the
<Switch/>
component gets the correct styling. We used to use https://github.com/umijs/babel-plugin-import to include this import at build-time, but the move toesbuild-loader
meant we can't use a babel plugin. The eslint plugin is there to make sure we do this manually :)
Ah okay, thanks for the explanation!
borsr=maryliag |
erm, let's try that again: bors r=maryliag |
Build succeeded: |
When the custom eslint-plugin-crdb was added to this repo [1], it was
accidentally only configured in the cluster-ui subproject. Add
eslint-plugin-crdb to the db-console subproject, fixing a lint failure
in the process.
[1] ba68179 (ui: use esbuild-loader in webpack configs, 2022-05-26)
Release note: None