Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: Adjust per_changefeed_limit to 128MiB #84702

Merged
merged 1 commit into from
Jul 20, 2022
Merged

release-22.1: Adjust per_changefeed_limit to 128MiB #84702

merged 1 commit into from
Jul 20, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 20, 2022 •
edited by shermanCRL
Loading

Backport 1/1 commits from #84686 on behalf of @shermanCRL.

/cc @cockroachdb/release

Adjust changefeed.memory.per_changefeed_limit to 128MiB. Default of 1GiB could pressure GC, causing GC assist, affecting foreground traffic.

Informs #84582

Release Notes (enterprise change): Reduce foreground latency impact when performing changefeed backfills.

Release justification: SQL latency was observed due to changefeed backfills driving GC assist

@shermanCRL
Adjust per_changefeed_limit to 128MiB
0ac3ee0 
Default of 1GiB could pressure GC, affecting foreground traffic
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 20, 2022 13:40
@blathers-crl blathers-crl bot requested review from shermanCRL and removed request for a team July 20, 2022 13:40
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-84686 branch from 57a15a7 to 0ac3ee0 Compare July 20, 2022 13:40
@blathers-crl blathers-crl bot requested review from ajwerner and miretskiy July 20, 2022 13:40
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 20, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 20, 2022 •
edited by shermanCRL
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@shermanCRL
Copy link
Contributor

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 20, 2022

👎 Rejected by PR status

@shermanCRL
Copy link
Contributor

bors retry

@craig
Copy link
Contributor

craig bot commented Jul 20, 2022

👎 Rejected by PR status

@shermanCRL
Copy link
Contributor

bors retry

@craig
Copy link
Contributor

craig bot commented Jul 20, 2022

This PR was included in a batch that successfully built, but then failed to merge into release-22.1 (it was a non-fast-forward update). It will be automatically retried.

@yuzefovich
Copy link
Member

No need to use bors on older release branches - you can just click Merge pull request button.

@yuzefovich
Copy link
Member

Actually, I'll do that myself to remove this PR from the bors queue.

bors r-

@craig
Copy link
Contributor

craig bot commented Jul 20, 2022

Canceled.

@yuzefovich yuzefovich merged commit 987fd47 into release-22.1 Jul 20, 2022
@yuzefovich yuzefovich deleted the blathers/backport-release-22.1-84686 branch July 20, 2022 18:01
@shermanCRL shermanCRL mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miretskiy miretskiy miretskiy approved these changes

@shermanCRL shermanCRL Awaiting requested review from shermanCRL shermanCRL is a code owner automatically assigned from cockroachdb/cdc-prs

@ajwerner ajwerner Awaiting requested review from ajwerner

Assignees

@shermanCRL shermanCRL

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @shermanCRL @yuzefovich @miretskiy