roachprod: change file permissions on prom/grafana files to 0777 #84670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
bors r=irfansharif |
|
Could someone share the context for this change? I imagine the previous permissions led to a failure somewhere. |
|
oof, my bad -- I didn't add a commit msg. Just updated the top comment in the PR. |
|
Build succeeded: |
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Jul 22, 2022
Recent regression from cockroachdb#84670. Was seeing the following: chmod: cannot access '/etc/grafana/provisioning/dashboards/cockroach.yaml': No such file or directory chmod: cannot access '/etc/grafana/provisioning/datasources/prometheus.yaml': No such file or directory Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
84689: opt: allow lookup joins to order on index columns r=DrewKimball a=DrewKimball It is possible for lookup joins to return the results of each lookup in the order of the lookup index. In the case when the input is ordered on a key, preserving the input ordering and then returning looked-up rows in index order is equivalent to performing a sort on the input ordering with the index columns appended. This patch teaches the optimizer that lookup joins can preserve the index ordering. This allows the optimizer to avoid sorting in some cases, which can significantly improve performance because sorts have to buffer all input rows. Fixes #84685 Release note: None 84920: sql: skip TestInformationSchemaMySQL r=wenyihu6 a=wenyihu6 Refs: #84915 Reason: There is a mismatch between MySQL version and CRDB in `pg_metadata_test.go`. More details in the issue above. Generated by bin/skip-test. Release justification: non-production code changes Release note: None 84930: roachprod: fix grafana-start permission issue r=irfansharif a=irfansharif Recent regression from #84670. Was seeing the following: chmod: cannot access '/etc/grafana/provisioning/dashboards/cockroach.yaml': No such file or directory chmod: cannot access '/etc/grafana/provisioning/datasources/prometheus.yaml': No such file or directory Release note: None Co-authored-by: DrewKimball <[email protected]> Co-authored-by: wenyihu3 <[email protected]> Co-authored-by: irfan sharif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a user ran the
grafana-startcmd on a roachprod cluster they did not spin up, the command would fail because of file permission errors. This patch prevents this.