sql: fix multiregion sqlsmith failure #84650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rytaft
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
yuzefovich
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Thanks!
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
pkg/internal/sqlsmith/alter.go line 22 at r1 (raw file):
"github.com/cockroachdb/cockroach/pkg/sql/sem/tree/treebin" "github.com/cockroachdb/cockroach/pkg/sql/types" "github.com/cockroachdb/cockroach/pkg/testutils/lint/passes/errwrap/testdata/src/github.com/cockroachdb/errors"
nit: this could be made shorter.
rafiss
requested changes
Jul 19, 2022
pkg/internal/sqlsmith/alter.go
Outdated
| @@ -19,6 +19,7 @@ import ( | |||
| "github.com/cockroachdb/cockroach/pkg/sql/sem/tree" | |||
| "github.com/cockroachdb/cockroach/pkg/sql/sem/tree/treebin" | |||
| "github.com/cockroachdb/cockroach/pkg/sql/types" | |||
| "github.com/cockroachdb/cockroach/pkg/testutils/lint/passes/errwrap/testdata/src/github.com/cockroachdb/errors" | |||
There was a problem hiding this comment.
i think this is the wrong import
Release note: None
RichardJCai
force-pushed
the
fix_mr_sqlsmith
branch
from
e73ef48 to
b560ec3
Compare
|
Thanks for reviewing all! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None
Fixes #78138