cluster-ui: allow dynamic timescale window from key buttons #84649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maryliag
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Small nit, otherwise
Reviewed 11 of 11 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
-- commits line 19 at r1:
nit: can you also mention you updated the tooltip for those buttons?
fixes cockroachdb#77007 Previously, controlling the time scale window using the arrow key buttons and 'Now' button would disable the dynamically moving window even when the end time = now. This commit makes it so that when the time window is changed to include the current time (i.e. endTime = now), the time window will be changed to dynamic to ensure the window is keep up to date with the current time. This commit also fixes the object construction of the time scale from session storage and corrects the 'Now' button tooltip label from 'past 1 day' to 'Most recent interval', with the other labels in the control panel ('next time interval' and 'previous time interval' being capitalized. Release note (bug fix): changing the time window using arrow buttons and 'Now' button will now properly turn the timeframe into a moving window when endTime = now.
xinhaoz
force-pushed
the
timescale-now-fix
branch
from
45143e9 to
7377c2b
Compare
|
TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #77007
Previously, controlling the time scale window using the arrow
key buttons and 'Now' button would disable the dynamically moving
window even when the end time = now. This commit makes it so that
when the time window is changed to include the current time (i.e.
endTime = now), the time window will be changed to dynamic to
ensure the window is keep up to date with the current time.
This commit also fixes the object construction of the time scale
from session storage and corrects the 'Now' button tooltip label from
'past 1 day' to 'Most recent interval'.
Release note (bug fix): changing the time window using arrow buttons
and 'Now' button will now properly turn the timeframe into a moving
window when endTime = now.
https://www.loom.com/share/54d65c04580747dc92f7e4976b953be6