Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rowenc: fix recent bugs with DOidWrappers and inverted indexes #84622

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

yuzefovich
Copy link
Member

Previously, we were using the passed-in datum asserting that it is
a DString whereas it could be a DOidWrapper, and this is now fixed.

Fixes: #84569.

Release note: None (no stable release with the bugs)

Previously, we were using the passed-in datum asserting that it is
a `DString` whereas it could be a `DOidWrapper`, and this is now fixed.

Release note: None (no stable release with the bugs)
@yuzefovich yuzefovich requested review from jordanlewis, mgartner and a team July 18, 2022 22:38
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @mgartner)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 19, 2022

Build succeeded:

@craig craig bot merged commit 5e53f01 into cockroachdb:master Jul 19, 2022
@yuzefovich yuzefovich deleted the fix-doidwrapper branch July 19, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: insert fails trying to update secondary index with a generated value
3 participants