Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "storageccl: use NewPebbleIterator in restore data processor" #84507

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Revert "storageccl: use NewPebbleIterator in restore data processor" #84507

merged 1 commit into from
Jul 15, 2022

Conversation

msbutler
Copy link
Collaborator

This reverts commit 4d1f66e.

Release Note: none

@msbutler msbutler self-assigned this Jul 15, 2022
@msbutler msbutler requested review from a team as code owners July 15, 2022 21:14
@msbutler msbutler requested review from a team and rhu713 July 15, 2022 21:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

erikgrinaker
erikgrinaker approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the panics should have been addressed with #84449, but stamping this and leaving it to your discretion.

@msbutler
Copy link
Collaborator Author

bors r=erikgrinaker

@msbutler
Copy link
Collaborator Author

bor r-
Will bors it later this evening if there is no quick fix to currrent failing roachtests

#84240 (comment)

#84162 (comment)

@msbutler
Copy link
Collaborator Author

bor r-

@craig
Copy link
Contributor

craig bot commented Jul 15, 2022

Build succeeded:

@craig craig bot merged commit a3d74c3 into cockroachdb:master Jul 15, 2022
@msbutler msbutler deleted the butler-revert-PebbleIter branch July 16, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker erikgrinaker approved these changes

@rhu713 rhu713 Awaiting requested review from rhu713

Assignees

@msbutler msbutler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbutler @cockroach-teamcity @erikgrinaker