descs: don't invalidate kvDescriptors cache #84187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the collection invalidated its view of descriptors read from KV after a descriptor was modified. This was necessary because the collection does not fully buffer writes to descriptors, so the descriptors stored in KV may change. This is problematic, because users of the `kvDescriptors` (virtual tables) must perform a round trip to refresh their descriptors cache after schema changes in the same transaction. To address this, this commit avoids invalidating the cache. Instead, when serving lookups that rely on the `kvDescriptors`, we will amend the cache with the contents of `uncommittedDescriptors` to ensure that a transaction sees its own modifications. Relates to cockroachdb#64673 Release note: None
|
This change is |
|
Closing as this isn't the change we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the collection invalidated its view of descriptors read from
KV after a descriptor was modified. This was necessary because the
collection does not fully buffer writes to descriptors, so the
descriptors stored in KV may change. This is problematic, because users
of the
kvDescriptors(virtual tables) must perform a round trip torefresh their descriptors cache after schema changes in the same
transaction.
To address this, this commit avoids invalidating the cache. Instead,
when serving lookups that rely on the
kvDescriptors, we will amend thecache with the contents of
uncommittedDescriptorsto ensure that atransaction sees its own modifications.
Relates to #64673
Release note: None