kv: remove special-case in FilterUnremovableReplicas for recently-added replicas #84160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed replicas In cockroachdb#17879/cockroachdb#17930, a special case was added to `FilterUnremovableReplicas` to avoid a common interaction where a newly-added replica was immediately removed when a range followed a replica addition with a replica removal. This special case was later refined in cockroachdb#34126. This was important at the time, but it no longer necessary because replica rebalancing (replica addition + removal) is performed atomically through a joint configuration. As a result, we can get rid of the subtle logic surrounding this special-case.
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17879/#17930, a special case was added to
FilterUnremovableReplicasto avoid a common interaction where a newly-added replica was immediately
removed when a range followed a replica addition with a replica removal.
This special case was later refined in #34126.
This was important at the time, but it is no longer necessary because replica
rebalancing (replica addition + removal) is performed atomically through a
joint configuration. As a result, we can get rid of the subtle logic
surrounding this special case.