-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: sql: Use one BytesMonitor for all IE created by IEFactory #84089
release-22.1: sql: Use one BytesMonitor for all IE created by IEFactory #84089
Conversation
Previously InternalExecutor's created via IEFactory would create a monitor that would never be closed. Now we have one monitor for all IEs that is closed with server is closed. Release note: None
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
…tServers We do not actually have to worry about closing the InternalExecutorFactoryMemMonitor. Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a clean backport, right?
but let's give it a few more days of baking on master.
Reviewed 15 of 15 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @RichardJCai)
Yeah SGTM |
Seems like no issues on master, merging. |
Backport
1/1 commits from #83678.
1/1 commits from #84212.
/cc @cockroachdb/release
Previously InternalExecutor's created via IEFactory would
create a monitor that would never be closed.
Now we have one monitor for all IEs that is closed with server
is closed.
Release note: None