Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: sql: Use one BytesMonitor for all IE created by IEFactory #84089

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

RichardJCai
Copy link
Contributor

@RichardJCai RichardJCai commented Jul 8, 2022

Backport
1/1 commits from #83678.
1/1 commits from #84212.

/cc @cockroachdb/release


Previously InternalExecutor's created via IEFactory would
create a monitor that would never be closed.

Now we have one monitor for all IEs that is closed with server
is closed.

Release note: None

Previously InternalExecutor's created via IEFactory would
create a monitor that would never be closed.

Now we have one monitor for all IEs that is closed with server
is closed.

Release note: None
@RichardJCai RichardJCai requested review from a team as code owners July 8, 2022 19:08
@RichardJCai RichardJCai requested a review from a team July 8, 2022 19:08
@blathers-crl
Copy link

blathers-crl bot commented Jul 8, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

…tServers

We do not actually have to worry about closing the
InternalExecutorFactoryMemMonitor.

Release note: None
@RichardJCai RichardJCai requested a review from yuzefovich July 12, 2022 18:59
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a clean backport, right?

:lgtm: but let's give it a few more days of baking on master.

Reviewed 15 of 15 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @RichardJCai)

@RichardJCai
Copy link
Contributor Author

RichardJCai commented Jul 12, 2022

This seems like a clean backport, right?

:lgtm: but let's give it a few more days of baking on master.

Reviewed 15 of 15 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @RichardJCai)

Yeah SGTM

@RichardJCai
Copy link
Contributor Author

Seems like no issues on master, merging.

@RichardJCai RichardJCai merged commit 7b257ec into cockroachdb:release-22.1 Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants