Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tenantsettingswatcher: remove the version gate #83873

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

yuzefovich
Copy link
Member

This commit removes the version gate for the tenant settings.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This commit removes the version gate for the tenant settings.

Release note: None
@yuzefovich yuzefovich force-pushed the remove-version-gate branch from 24d8ecb to ad06d0c Compare July 6, 2022 00:20
@yuzefovich yuzefovich marked this pull request as ready for review July 6, 2022 04:15
@yuzefovich yuzefovich requested a review from a team July 6, 2022 04:15
@yuzefovich yuzefovich requested a review from a team as a code owner July 6, 2022 04:15
@yuzefovich yuzefovich requested review from knz and irfansharif July 6, 2022 04:15
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @irfansharif and @knz)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 6, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 6, 2022

Build succeeded:

@craig craig bot merged commit ce1b42b into cockroachdb:master Jul 6, 2022
@yuzefovich yuzefovich deleted the remove-version-gate branch July 6, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants