Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: [CRDB-2743] sql: create builltin generator crdb_internal.probe_range #83820

Merged
merged 1 commit into from
Jul 13, 2022
Merged

release-22.1: [CRDB-2743] sql: create builltin generator crdb_internal.probe_range #83820

merged 1 commit into from
Jul 13, 2022

Conversation

Santamaura
Copy link
Contributor

@Santamaura Santamaura commented Jul 5, 2022 •
edited
Loading

Backport 1/1 commits from #79546.

/cc @cockroachdb/release

Previously there was difficulty in diagnosing kv layer health when
an incident occurs. This patch introduces the new virtual table
crdb_internal.probe_range which utilizes the kvprober to probe
each range to determine if the range can be reached or not.

resolves #61695

Release note: None

Screen Shot 2022-04-20 at 1 15 17 PM

Release justification: Observability QoL improvement

@Santamaura
sql: create builtin generator crdb_internal.probe_ranges
c333b2f 
Previously there was difficulty diagnosing kv layer health
when an incident occurs. This patch introduces a new virtual
table crdb_internal.probe_ranges which utilitzes the kvprober
probe each range to determine if the range can be reached or
not.

resolves cockroachdb#61695

Release note: None
@Santamaura Santamaura requested a review from a team as a code owner July 5, 2022 16:17
@Santamaura Santamaura requested a review from a team July 5, 2022 16:17
@blathers-crl
Copy link

blathers-crl bot commented Jul 5, 2022 •
edited by Santamaura
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@joshimhoff
Copy link
Collaborator

Yay to this!

@Santamaura
Copy link
Contributor Author

@tbg when you have a free second, can you also review/approve this backport as well? Thanks!

joshimhoff
joshimhoff approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@joshimhoff joshimhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Santamaura Santamaura merged commit 2192381 into cockroachdb:release-22.1 Jul 13, 2022
@Santamaura Santamaura deleted the backport22.1-79546 branch July 13, 2022 14:41
Santamaura added a commit to Santamaura/cockroach that referenced this pull request Jul 13, 2022
@Santamaura
docs: fix missing volatility column for prober builtin generated doc
0cfdfb7 
This patch fixes the issue of the missing volatility column for the
prober builtin in generated docs. Backport cockroachdb#83820 did not have the
volatility column from cockroachdb#84038.

Release note: None
@Santamaura Santamaura mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshimhoff joshimhoff joshimhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Santamaura @cockroach-teamcity @joshimhoff