Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: handle single clause UPDATE ... SET for JSONB descriptors #83764

Closed
wants to merge 2 commits into from

Conversation

otan
Copy link
Contributor

@otan otan commented Jul 4, 2022

See individual commits for details.

Please see #77434 (comment).

otan added 2 commits July 4, 2022 11:54
* Introduce a tree.ColumnRef type that includes a column name and
  reference, similar to PG's definition.
* Make this work for single SELECT statements for this commit only.

Release note: None
This commit re-uses `json_set` to deal with array subscript assignments
for JSON.

Release note (sql change): Using JSONB style subscripts for UPDATE
clauses (e.g. `UPDATE t SET j['a'] = 1, k['a'] = 2`) now works.
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan changed the title sql: sql: handle single clause UPDATE ... SET for JSONB descriptors Jul 4, 2022
@otan otan requested a review from mgartner July 4, 2022 02:08
@otan otan closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants