iterutil: More ergonomic interface #83737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbaptist
requested review from
a team and
gh-casper
and removed request for
a team
|
This change is |
postamar
approved these changes
Jul 4, 2022
| // Done tells if the error is ErrStopIteration, i.e., should the iteration stop. | ||
| func Done(err error) bool { return errors.Is(err, errStopIteration) } | ||
| // Map the nil if it is StopIteration, or keep the error otherwise | ||
| func Map(err error) error { |
There was a problem hiding this comment.
If we want iterutil to be more monadic shouldn't this be a Filter instead of a Map?
There was a problem hiding this comment.
I spent a little time thinking about how to do this, and couldn't come up with a great solution. If anything the original Done was much closer to Filter. The problem with it in this case, is trying to both exit a loop early as well as return either success or fail.
Let me know if you think I should look at a different alternative or just merge this one in.
There was a problem hiding this comment.
Your change is a strict improvement over what there was so I feel very good about it 👍
Replace the Done call in iterutil with Map. This removes a lot of duplicate code and simplifies the way it is used. There are no functional changes as a result of this. Release note: None
andrewbaptist
force-pushed
the
ergonomic_iterutil
branch
from
e3c3c87 to
075da4b
Compare
|
bors r=postamar |
|
Build failed (retrying...): |
|
Build succeeded: |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the Done call in iterutil with Map. This removes a lot of
duplicate code and simplifies the way it is used. There are no
functional changes as a result of this.
Release note: None