roachtest: unskip large decommissionBench test #83733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This extends the timeout of the large, 3000 warehouse decommission benchmark roachtest to 3 hours, since it can take up to an hour for the test to import data, achieve range count balance, and ramp up its workload. This was skipped in cockroachdb#83445 due to frequent timeouts at the 1hr mark. It also adds a `--max-rate` parameter to the workload generator in order to ensure the cluster avoids overload. Release note: None
AlexTalks
force-pushed
the
unskip_large_decomm_bench
branch
from
4c3a631 to
e5d33a1
Compare
aayushshah15
approved these changes
Jul 4, 2022
|
bors r+ |
|
Build succeeded: |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the timeout of the large, 3000 warehouse decommission
benchmark roachtest to 3 hours, since it can take up to an hour for the
test to import data, achieve range count balance, and ramp up its
workload. This was skipped in #83445 due to frequent timeouts at the 1hr
mark.
It also adds a
--max-rateparameter to the workload generator in orderto ensure the cluster avoids overload.
Closes #82870
Release note: None