-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backupccl: create tree.SystemUsers, a new DescriptorCoverage enum #83526
Merged
craig
merged 1 commit into
cockroachdb:master
from
msbutler:butler-restore-system-users
Jun 29, 2022
Merged
backupccl: create tree.SystemUsers, a new DescriptorCoverage enum #83526
craig
merged 1 commit into
cockroachdb:master
from
msbutler:butler-restore-system-users
Jun 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamaru
reviewed
Jun 28, 2022
adityamaru
reviewed
Jun 28, 2022
adityamaru
suggested changes
Jun 28, 2022
msbutler
force-pushed
the
butler-restore-system-users
branch
from
June 28, 2022 21:51
032d8dc
to
0651d14
Compare
adityamaru
approved these changes
Jun 29, 2022
Previously during planning and execution RESTORE SYSTEM USERS was identified by a `jobDetails` field. This refactor now identifies this flavor of restore with a new DescriptorCoverage enum value, `tree.SystemUsers. This refactor eases the logic around exposing extra processing steps for flavors of backup/restore that target different sets of descriptors. Release note: None
msbutler
force-pushed
the
butler-restore-system-users
branch
from
June 29, 2022 14:16
0651d14
to
4548df3
Compare
TFTR!!! bors r=adityamaru |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously during planning and execution RESTORE SYSTEM USERS was identified by
a
jobDetails
field. This refactor now identifies this flavor ofrestore with a new DescriptorCoverage enum value, `tree.SystemUsers.
This refactor eases the logic around exposing extra processing steps for
flavors of backup/restore that target different sets of descriptors.
Release note: None