Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: create tree.SystemUsers, a new DescriptorCoverage enum #83526

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Jun 28, 2022

Previously during planning and execution RESTORE SYSTEM USERS was identified by
a jobDetails field. This refactor now identifies this flavor of
restore with a new DescriptorCoverage enum value, `tree.SystemUsers.

This refactor eases the logic around exposing extra processing steps for
flavors of backup/restore that target different sets of descriptors.

Release note: None

@msbutler msbutler requested a review from adityamaru June 28, 2022 18:19
@msbutler msbutler requested a review from a team as a code owner June 28, 2022 18:19
@msbutler msbutler requested a review from a team June 28, 2022 18:19
@msbutler msbutler requested a review from a team as a code owner June 28, 2022 18:19
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler msbutler self-assigned this Jun 28, 2022
pkg/sql/sem/tree/backup.go Outdated Show resolved Hide resolved
pkg/sql/sem/tree/backup.go Show resolved Hide resolved
pkg/ccl/backupccl/restore_planning.go Outdated Show resolved Hide resolved
pkg/ccl/backupccl/restore_planning.go Outdated Show resolved Hide resolved
pkg/ccl/backupccl/restore_job.go Outdated Show resolved Hide resolved
@adityamaru adityamaru self-requested a review June 28, 2022 21:00
@msbutler msbutler force-pushed the butler-restore-system-users branch from 032d8dc to 0651d14 Compare June 28, 2022 21:51
Previously during planning and execution RESTORE SYSTEM USERS was identified by
a `jobDetails` field. This refactor now identifies this flavor of
restore with a new  DescriptorCoverage enum value, `tree.SystemUsers.

This refactor eases the logic around exposing extra processing steps for
flavors of backup/restore that target different sets of descriptors.

Release note: None
@msbutler msbutler force-pushed the butler-restore-system-users branch from 0651d14 to 4548df3 Compare June 29, 2022 14:16
@msbutler
Copy link
Collaborator Author

TFTR!!!

bors r=adityamaru

@craig
Copy link
Contributor

craig bot commented Jun 29, 2022

Build succeeded:

@craig craig bot merged commit 0917fdc into cockroachdb:master Jun 29, 2022
@msbutler msbutler deleted the butler-restore-system-users branch June 29, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants